Details

I'm not sure why this key was removed, I'm not sure it was done intentionally, cc @Justicea83

Also, I removed the unused isPolicy field. Its only usage was removed here. You can confirm by running the following from the App directory

ag 'isPolicy(?!ExpenseChat)'

That just finds all the occurrences of isPolicy not followed by ExpenseChat, and you can see there's only one such occurrence and it's unrelated:

Fixed Issues

$ #12452

Tests

1. Go to here, comment out the function contents and replace it with:

   throw new ExpError('9A051C09-AD6C-44A2-B7BC-8F3B486DBCC3', 'You cannot delete this policy because it is set as the domain restricted one for a domain security group.', 'Cannot delete this policy');

2. Sign into an account on NewDot and make a workspace.

3. Go offline.

4. Go to Settings -> Workspaces -> <your_workspace> -> ... -> Delete Workspace to delete the workspace.

5. Verify that the workspace now appears with strikethrough. On web and desktop, hovering over the deleted workspace, your mouse style should change to disabled. On all platforms you should no longer be able to click into the workspace.

6. Go back to the home page.

7. Come back online.

8. Verify that there is a red dot over the settings menu icon.

9. Open the settings page.

10. Verify that there is a red dot over the Workspaces menu item

11. Click on the Workspaces menu item

12. Verify that there is a red dot over your individual workspace, and that there is an error message with an x next to it displaying beneath it.

13. Click on the x to dismiss the error message.

14. Verify that you can now click into the workspace again.

• Verify that no errors appear in the JS console

QA Steps

1. Sign into "an account with the correct setup" applausetester@applause.expensifail.com
2. Perform the test steps above ^.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots

Web